Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore status changing permission check if previous value is not a string #1661

Merged
merged 1 commit into from
Sep 24, 2023
Merged

Ignore status changing permission check if previous value is not a string #1661

merged 1 commit into from
Sep 24, 2023

Conversation

caiosba
Copy link
Contributor

@caiosba caiosba commented Sep 21, 2023

Description

Ignore status changing permission check if previous value is not a string. Fixes CV2-3764.

How has this been tested?

TDD. I was able to reproduce the bug in a unit test.

Checklist

  • I have performed a self-review of my own code
  • I have added unit and feature tests, if the PR implements a new feature or otherwise would benefit from additional testing
  • I have added regression tests, if the PR fixes a bug
  • I have added logging, exception reporting, and custom tracing with any additional information required for debugging
  • I considered secure coding practices when writing this code. Any security concerns are noted above.
  • I have commented my code in hard-to-understand areas, if any
  • I have made needed changes to the README
  • My changes generate no new warnings
  • If I added a third party module, I included a rationale for doing so and followed our current guidelines

@codeclimate
Copy link

codeclimate bot commented Sep 21, 2023

Code Climate has analyzed commit 6fb9b49 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (100% is the threshold).

This pull request will bring the total coverage in the repository to 99.7% (0.0% change).

View more on Code Climate.

@caiosba caiosba merged commit 8a80418 into develop Sep 24, 2023
@caiosba caiosba deleted the fix/CV2-3764-status-permission-check branch September 24, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melsawy melsawy melsawy approved these changes

@DGaffney DGaffney Awaiting requested review from DGaffney DGaffney is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caiosba @melsawy